Hibernation: Add check for disk space requirement #4122
+74
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adityagesh
commented
Nov 21, 2025
adityagesh
commented
- Hibernation requires free disk space proportional to RAM of the machine. LISA currently does not support os disk size as a requirement.
- Azure does not support Hibernation for VM with memory larger than 256 GB
adityagesh
force-pushed
the
aditya/hibernation_precheck
branch
3 times, most recently
from
1709020 to
ba9870a
Compare
Collaborator
|
LGTM |
adityagesh
force-pushed
the
aditya/hibernation_precheck
branch
3 times, most recently
from
6619dfd to
da8f248
Compare
LiliDeng
reviewed
Nov 24, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds disk space validation for VM hibernation to prevent setup failures. The changes implement pre-flight checks for disk space requirements and improve error handling for space-related hibernation failures.
- Adds a new function
check_hibernation_disk_requirements()that validates available disk space based on VM RAM size - Adds error pattern detection for defragmentation space errors in the hibernation setup tool
- Integrates the disk space check into the Power test suite's
before_casehook to fail fast before attempting hibernation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lisa/tools/hibernation_setup.py | Adds regex pattern and error handling for defragmentation space errors during hibernation setup |
| lisa/microsoft/testsuites/power/common.py | Implements new disk space validation function that checks RAM size and available disk space against hibernation requirements |
| lisa/microsoft/testsuites/power/power.py | Integrates disk space check into test suite setup by calling it in the before_case hook |
adityagesh
force-pushed
the
aditya/hibernation_precheck
branch
3 times, most recently
from
99d6976 to
28f349e
Compare
Copilot finished reviewing on behalf of
LiliDeng
November 26, 2025 02:11
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
1. Hibernation requires free disk space proportional to RAM of the machine. LISA currently does not support os disk size as a requirement. 2. Azure does not support Hibernation for VM with memory larger than 256 GB
adityagesh
force-pushed
the
aditya/hibernation_precheck
branch
from
28f349e to
7abbc51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.